HomePhabricator

Don't call flush() when emitting responses

Description

Don't call flush() when emitting responses

Summary: Fixes T7620. I don't fully understand exactly what's going on here, but we don't actually need to call flush().

Test Plan:

  • Put timing code around the echo.
  • Made a fake page that emitted a lot of data.
  • Saw the echo block proportionate to data size under curl --limit-rate ....
  • See T7620.
  • Downloaded a large file, got a reasonable progress bar and no obvious memory use issues.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: jlarouche, rbalik, epriestley

Maniphest Tasks: T7620

Differential Revision: https://secure.phabricator.com/D12127

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 23 2015, 4:09 PM
Reviewer
btrahan
Differential Revision
D12127: Don't call flush() when emitting responses
Parents
rPc4d2fb087ee8: Clear floats around conpherence-edited transactions
Branches
Unknown
Tags
Unknown
Tasks
T7620: git unable to pull after upgrading to latest