Page MenuHomePhabricator

Don't call flush() when emitting responses
ClosedPublic

Authored by epriestley on Mar 21 2015, 7:30 PM.

Details

Summary

Fixes T7620. I don't fully understand exactly what's going on here, but we don't actually need to call flush().

Test Plan
  • Put timing code around the echo.
  • Made a fake page that emitted a lot of data.
  • Saw the echo block proportionate to data size under curl --limit-rate ....
  • See T7620.
  • Downloaded a large file, got a reasonable progress bar and no obvious memory use issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't call flush() when emitting responses.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 3:50 PM
This revision was automatically updated to reflect the committed changes.