HomePhabricator

Reject SCP-style URIs with explicit protocols in Diffusion

Description

Reject SCP-style URIs with explicit protocols in Diffusion

Summary:
Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan:
{F75486}

Also set some valid URIs.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3619

Differential Revision: https://secure.phabricator.com/D7431

Details

Provenance
epriestleyAuthored on Oct 27 2013, 5:32 AM
Reviewer
btrahan
Differential Revision
D7431: Reject SCP-style URIs with explicit protocols in Diffusion
Parents
rP59922b78b9bc: Make Phabricator clone bare git repositories
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline