Page MenuHomePhabricator

Reject SCP-style URIs with explicit protocols in Diffusion
ClosedPublic

Authored by epriestley on Oct 27 2013, 5:36 AM.
Tags
None
Referenced Files
F15374297: D7431.diff
Wed, Mar 12, 6:19 PM
F15352765: D7431.id16758.diff
Mon, Mar 10, 6:27 PM
F15333156: D7431.id16725.diff
Sat, Mar 8, 12:27 AM
Unknown Object (File)
Feb 27 2025, 4:56 PM
Unknown Object (File)
Jan 28 2025, 10:55 AM
Unknown Object (File)
Dec 31 2024, 9:53 PM
Unknown Object (File)
Dec 26 2024, 5:35 PM
Unknown Object (File)
Nov 27 2024, 11:40 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion
Summary

Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan

{F75486}

Also set some valid URIs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped