Page MenuHomePhabricator

Reject SCP-style URIs with explicit protocols in Diffusion
ClosedPublic

Authored by epriestley on Oct 27 2013, 5:36 AM.
Tags
None
Referenced Files
F19507014: D7431.id16758.diff
Fri, Jan 9, 5:10 PM
F19506416: D7431.id16725.diff
Fri, Jan 9, 4:46 PM
F19245185: D7431.id.diff
Mon, Dec 22, 2:00 AM
F18904994: D7431.diff
Nov 8 2025, 12:19 PM
F18823196: D7431.id16725.diff
Oct 23 2025, 10:34 AM
F18803927: D7431.diff
Oct 18 2025, 4:54 AM
F18799232: D7431.id16725.diff
Oct 17 2025, 12:47 PM
F18799231: D7431.id16725.diff
Oct 17 2025, 12:47 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion
Summary

Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan

{F75486}

Also set some valid URIs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped