Page MenuHomePhabricator

Reject SCP-style URIs with explicit protocols in Diffusion
ClosedPublic

Authored by epriestley on Oct 27 2013, 5:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2026, 5:58 PM
Unknown Object (File)
Feb 25 2026, 1:35 PM
Unknown Object (File)
Jan 19 2026, 4:46 PM
Unknown Object (File)
Jan 9 2026, 5:10 PM
Unknown Object (File)
Jan 9 2026, 4:46 PM
Unknown Object (File)
Dec 22 2025, 2:00 AM
Unknown Object (File)
Nov 8 2025, 12:19 PM
Unknown Object (File)
Oct 23 2025, 10:34 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion
Summary

Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan

{F75486}

Also set some valid URIs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped