HomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language

Tags
None
Referenced Files
F1740684: Screen Shot 2016-07-28 at 10.11.46 AM.png
Jul 28 2016, 6:00 PM
F1740685: Screen Shot 2016-07-28 at 10.14.07 AM.png
Jul 28 2016, 6:00 PM
F1740683: Screen Shot 2016-07-28 at 10.14.13 AM.png
Jul 28 2016, 6:00 PM
F1740686: Screen Shot 2016-07-28 at 10.11.49 AM.png
Jul 28 2016, 6:00 PM
Subscribers
None

Description

Fix "Blocked" task queries with multiple subtasks, and update language

Summary:
Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.

Test Plan:

  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8126

Differential Revision: https://secure.phabricator.com/D16340