Page MenuHomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic

Authored by epriestley on Jul 28 2016, 5:21 PM.
Tags
None
Referenced Files
F15414707: D16340.id39294.diff
Thu, Mar 20, 2:03 AM
F15407102: D16340.diff
Tue, Mar 18, 3:44 PM
F15390222: D16340.id.diff
Sat, Mar 15, 6:02 AM
Unknown Object (File)
Sun, Mar 2, 9:54 AM
Unknown Object (File)
Feb 16 2025, 7:10 AM
Unknown Object (File)
Feb 12 2025, 11:58 AM
Unknown Object (File)
Feb 9 2025, 2:04 AM
Unknown Object (File)
Jan 24 2025, 3:02 PM
Subscribers
None

Details

Summary

Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.
Test Plan
  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable