Page MenuHomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic

Authored by epriestley on Jul 28 2016, 5:21 PM.
Tags
None
Referenced Files
F19838379: D16340.id39298.diff
Wed, Mar 11, 5:00 PM
F19809101: D16340.id39298.diff
Tue, Mar 3, 8:07 AM
F19528608: D16340.diff
Jan 19 2026, 10:27 AM
F19525881: D16340.id39298.diff
Jan 18 2026, 12:33 PM
F19082123: D16340.id39298.diff
Dec 2 2025, 9:49 AM
F19069658: D16340.id.diff
Nov 30 2025, 2:57 PM
F19062990: D16340.diff
Nov 29 2025, 5:32 PM
F18902954: D16340.diff
Nov 8 2025, 3:27 AM
Subscribers
None

Details

Summary

Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.
Test Plan
  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable