Page MenuHomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic

Authored by epriestley on Jul 28 2016, 5:21 PM.
Tags
None
Referenced Files
F18777694: D16340.id39298.diff
Sat, Oct 11, 4:33 AM
F18706710: D16340.diff
Sun, Sep 28, 5:28 PM
F18685074: D16340.diff
Fri, Sep 26, 10:35 AM
F18678777: D16340.diff
Thu, Sep 25, 11:19 PM
F18629960: D16340.id39294.diff
Sep 16 2025, 10:22 AM
F18628437: D16340.diff
Sep 16 2025, 6:19 AM
F18624899: D16340.id39298.diff
Sep 15 2025, 9:22 PM
F18620694: D16340.id39294.diff
Sep 15 2025, 6:04 AM
Subscribers
None

Details

Summary

Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.
Test Plan
  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable