HomePhabricator

Remove an old digest in Celerity code and some obsolete configuration options

Authored by epriestley on Jan 2 2019, 4:28 AM.

Description

Remove an old digest in Celerity code and some obsolete configuration options

Summary:
Ref T12509. This upgrades a weakDigest() callsite to SHA256-HMAC and removes three config options:

  • celerity.resource-hash: Now hard-coded, since the use case for ever adjusting it was very weak.
  • celerity.enable-deflate: Intended to make cache inspection easier, but we haven't needed to inspect caches in ~forever.
  • celerity.minify: Intended to make debugging minification easier, but we haven't needed to debug this in ~forever.

In the latter two cases, the options were purely developer-focused, and it's easy to go add an && false somewhere in the code if we need to disable these features to debug something, but the relevant parts of the code basically work properly and never need debugging. These options were excessively paranoid, based on the static resource enviroment at Facebook being far more perilous.

The first case theoretically had end-user utility for fixing stuck content caches. In modern Phabricator, it's not intuitive that you'd go adjust a Config option to fix this. I don't recall any users ever actually running into problems here, though.

(An earlier version of this change did more magic with celerity.resource-hash, but this ended up with a more substantial simplification.)

Test Plan: Grepped for removed configuration options.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12509

Differential Revision: https://secure.phabricator.com/D19941