This logic causes an exception because getPHID() is called on a fragment that has no latest version. This fixes the code so that in this scenario, it returns an empty array (with no path to be added to the ZIP).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4205: Implement Phragment
- Commits
- Restricted Diffusion Commit
rPacd5d5ae4a39: Correctly handle downloading ZIP with empty directories in Phragment
Downloaded the ZIP successfully after the patch was applied.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
(I'm not 100% sure we don't already, but maybe we should add an empty directory to the zip? We can kind of get away without doing that because Git doesn't, but if we don't have a compelling technical reason not to do this I think it's a more intuitive behavior.)