HomePhabricator

Simplify Herald logic for loading Differential changes

Description

Simplify Herald logic for loading Differential changes

Summary: Ref T4045. These three methods are fairly copy-pastey. Provide a more formal DifferentialHunk API for querying various types of line ranges.

Test Plan: Used test console to verify that "added content", "removed content", and "changed content" rules still produce the same data.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4045

Differential Revision: https://secure.phabricator.com/D8764

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Apr 14 2014, 7:06 PM
Reviewer
btrahan
Differential Revision
D8764: Simplify Herald logic for loading Differential changes
Parents
rP2509c6b0f57d: Fixing z-index on calendar date badges.
Branches
Unknown
Tags
Unknown
Tasks
T4045: Store diffs as binary, not UTF-8

Event Timeline