Page MenuHomePhabricator

Simplify Herald logic for loading Differential changes
ClosedPublic

Authored by epriestley on Apr 12 2014, 1:23 PM.
Tags
None
Referenced Files
F15509596: D8764.id20790.diff
Wed, Apr 16, 2:31 PM
F15508189: D8764.id.diff
Wed, Apr 16, 3:01 AM
F15506362: D8764.diff
Tue, Apr 15, 10:32 AM
F15456108: D8764.diff
Sun, Mar 30, 7:09 AM
F15402831: D8764.id20790.diff
Tue, Mar 18, 12:34 AM
F15339122: D8764.diff
Mar 9 2025, 2:28 PM
F15312104: D8764.id20806.diff
Mar 6 2025, 1:59 PM
Unknown Object (File)
Feb 25 2025, 6:28 PM
Subscribers

Details

Summary

Ref T4045. These three methods are fairly copy-pastey. Provide a more formal DifferentialHunk API for querying various types of line ranges.

Test Plan

Used test console to verify that "added content", "removed content", and "changed content" rules still produce the same data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Simplify Herald logic for loading Differential changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2014, 6:36 PM
epriestley updated this revision to Diff 20806.

Closed by commit rPaaf1320b02cf (authored by @epriestley).