HomePhabricator

Remove most callsites to Controller->renderHandlesForPHIDs()

Authored by epriestley.

Description

Remove most callsites to Controller->renderHandlesForPHIDs()

Summary: Ref T7689. This moves most of the easy/testable callsites off Controller->renderHandlesForPHIDs().

Test Plan:

  • Viewed a file; viewed author; viewed "attached" tab.
  • Viewed a mock; viewed attached tasks.
  • Viewed a credential; viewed "Used By".
  • Viewed a paste; viewed author; viewed forks; viewed forked from.
  • Viewed a dashboard; viewed panel list.
  • Viewed a dashboard panel; viewed "Appears On".
  • Viewed a Phortune account; viewed "Members"; viewed payment methods.
  • Viewed a Phortune merchant account; viewed "Members".
  • Viewed Phortune account switcher; viewed "Accounts".
    • I just removed "Members:" here since it felt kind of out-of-place anyway.
  • Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
  • Viewed a Phargment snapshot, viewed "Fragment".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12207

Details

Committed
epriestleyMar 31 2015, 12:48 PM
Pushed
epriestleyMar 31 2015, 12:48 PM
Reviewer
btrahan
Differential Revision
D12207: Remove most callsites to Controller->renderHandlesForPHIDs()
Parents
rPdec03cf07683: Prepare a replacement for Controller->renderHandlesForPHIDs()
Branches
Unknown
Tags
Unknown
Tasks
T7689: Load handles just-in-time