Page MenuHomePhabricator

Remove most callsites to Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 2:05 PM.
Tags
None
Referenced Files
F14064086: D12207.diff
Mon, Nov 18, 9:45 PM
F14003626: D12207.diff
Sat, Oct 26, 8:29 AM
F14003585: D12207.diff
Sat, Oct 26, 8:00 AM
F13961595: D12207.id29357.diff
Oct 15 2024, 5:37 AM
Unknown Object (File)
Oct 6 2024, 4:27 PM
Unknown Object (File)
Oct 4 2024, 12:57 PM
Unknown Object (File)
Sep 15 2024, 7:10 AM
Unknown Object (File)
Aug 26 2024, 9:23 AM

Details

Summary

Ref T7689. This moves most of the easy/testable callsites off Controller->renderHandlesForPHIDs().

Test Plan
  • Viewed a file; viewed author; viewed "attached" tab.
  • Viewed a mock; viewed attached tasks.
  • Viewed a credential; viewed "Used By".
  • Viewed a paste; viewed author; viewed forks; viewed forked from.
  • Viewed a dashboard; viewed panel list.
  • Viewed a dashboard panel; viewed "Appears On".
  • Viewed a Phortune account; viewed "Members"; viewed payment methods.
  • Viewed a Phortune merchant account; viewed "Members".
  • Viewed Phortune account switcher; viewed "Accounts".
    • I just removed "Members:" here since it felt kind of out-of-place anyway.
  • Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
  • Viewed a Phargment snapshot, viewed "Fragment".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove most callsites to Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.