Page MenuHomePhabricator

Remove most callsites to Controller->renderHandlesForPHIDs()

Authored by epriestley on Mar 30 2015, 2:05 PM.



Ref T7689. This moves most of the easy/testable callsites off Controller->renderHandlesForPHIDs().

Test Plan
  • Viewed a file; viewed author; viewed "attached" tab.
  • Viewed a mock; viewed attached tasks.
  • Viewed a credential; viewed "Used By".
  • Viewed a paste; viewed author; viewed forks; viewed forked from.
  • Viewed a dashboard; viewed panel list.
  • Viewed a dashboard panel; viewed "Appears On".
  • Viewed a Phortune account; viewed "Members"; viewed payment methods.
  • Viewed a Phortune merchant account; viewed "Members".
  • Viewed Phortune account switcher; viewed "Accounts".
    • I just removed "Members:" here since it felt kind of out-of-place anyway.
  • Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
  • Viewed a Phargment snapshot, viewed "Fragment".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Remove most callsites to Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.