(stable) Use "@" to silence "GC list" warnings from "apc_store()" and…
a338b1f43308
Actions

Description

(stable) Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"

Summary:
Fixes T13525. Since D21044, the intermittent GC list warnings are treated more severely and can become user-visible errors.

Silence them, since this seems to be the only realistic response in most versions of APC/APCu.

Test Plan: Will deploy.

Maniphest Tasks: T13525

Differential Revision: https://secure.phabricator.com/D21179

Details

Provenance

epriestley	Authored on Apr 28 2020, 10:53 AM
epriestley	Pushed on Apr 28 2020, 11:14 AM

Differential Revision

D21179: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"

Parents

rPe17c49699309: (stable) Fix an invalid index access for synthetic lint inline comments from…

Branches

Unknown

Tags

Unknown

Tasks

T13525: "apcu_store()" may raise "GC cache entry ..." errors

Build Status

Buildable 24256
Build 33408: Run Core Tests

Event Timeline

epriestley committed rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and… (authored by epriestley).Apr 28 2020, 11:13 AM

epriestley added a task: T13525: "apcu_store()" may raise "GC cache entry ..." errors.

epriestley added an edge: D21179: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()".

Harbormaster completed building B24256: rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and….Apr 28 2020, 11:15 AM

Changes (2)

Path

Size

src/

infrastructure/

cache/

PhutilAPCKeyValueCache.php

support/

startup/

PhabricatorClientLimit.php

rPa338b1f43308

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php