HomePhabricator

Make Phage agents stream output continuously

Description

Make Phage agents stream output continuously

Summary:
Ref T2794. Currently, the Phage agent waits until the remote command completes before sending output back to the controller.

Instead, stream output continuously.

Also work around some kind of weirdness with error reporting that I hit but couldn't immediately figure out (maybe PHP7-related?).

Test Plan: Ran bin/phage remote --hosts ... upgrade, etc., and saw a steady stream of output across multiple hosts.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2794

Differential Revision: https://secure.phabricator.com/D17378

Details

Provenance
epriestleyAuthored on Feb 17 2017, 10:11 PM
epriestleyPushed on Feb 18 2017, 12:57 AM
Reviewer
chad
Differential Revision
D17378: Make Phage agents stream output continuously
Parents
rPHU9f66fbd018f1: In PhutilLogFileChannel, don't log empty messages
Branches
Unknown
Tags
Unknown
Tasks
T2794: Implement Phage (like Hypershell)
Build Status
Buildable 15691
Build 20728: Run Core Tests