Page MenuHomePhabricator

Make Phage agents stream output continuously
ClosedPublic

Authored by epriestley on Feb 17 2017, 10:42 PM.
Tags
None
Referenced Files
F13060700: D17378.diff
Fri, Apr 19, 6:15 PM
Unknown Object (File)
Thu, Apr 11, 9:01 AM
Unknown Object (File)
Sun, Apr 7, 4:34 AM
Unknown Object (File)
Thu, Mar 28, 1:17 PM
Unknown Object (File)
Fri, Mar 22, 2:11 PM
Unknown Object (File)
Mar 19 2024, 5:47 PM
Unknown Object (File)
Mar 19 2024, 5:47 PM
Unknown Object (File)
Mar 19 2024, 5:47 PM
Subscribers
None

Details

Summary

Ref T2794. Currently, the Phage agent waits until the remote command completes before sending output back to the controller.

Instead, stream output continuously.

Also work around some kind of weirdness with error reporting that I hit but couldn't immediately figure out (maybe PHP7-related?).

Test Plan

Ran bin/phage remote --hosts ... upgrade, etc., and saw a steady stream of output across multiple hosts.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 17 2017, 11:50 PM
This revision was automatically updated to reflect the committed changes.