Page MenuHomePhabricator

Minor improvement to XHPASTSyntaxErrorException message
ClosedPublic

Authored by joshuaspence on Jul 17 2014, 1:38 PM.
Tags
None
Referenced Files
F14035796: D9961.id23903.diff
Sun, Nov 10, 7:38 AM
F14026031: D9961.diff
Thu, Nov 7, 10:18 PM
F14025373: D9961.diff
Thu, Nov 7, 5:11 PM
F14013393: D9961.id23903.diff
Sat, Nov 2, 6:38 AM
F13983692: D9961.id23912.diff
Sun, Oct 20, 8:08 AM
F13972103: D9961.id23903.diff
Thu, Oct 17, 5:11 PM
F13966395: D9961.id23903.diff
Wed, Oct 16, 7:53 AM
F13966357: D9961.id23903.diff
Wed, Oct 16, 7:44 AM
Subscribers

Details

Summary

Trim trailing newline from exception message.

Test Plan

Before

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4\n",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

After

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Minor improvement to XHPASTSyntaxErrorException message.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 2:14 PM