Reorganize PhutilDaemon into Overseers, Pools and Daemons in libphutil
Auditedbe546154255c
Actions

Description

Reorganize PhutilDaemon into Overseers, Pools and Daemons in libphutil

Summary:
Ref T12298. Ultimate goal is to let daemon pools scale down to 0 daemons when they aren't doing anything. This doesn't do that yet (and attempts to change no behavior).

This reorganizes the daemon code to make this change easier. Currently, some daemons are in pools and some are not. Intead, make everything a pool (the Pull and Trigger daemons just get pools with maximum size 1).

New object hiearchy is:

Overseer
- Pool
  - Daemon

...and those objects each pretty much take care of their own stuff, instead of having daemons reach up into the Overseer to dispatch events back to themselves.

Test Plan:

Ran phd debug, phd start, phd stop, phd status, etc.
Reviewed daemons in web console.
Changed config, saw daemons automatically restart.
Sent daemons signals.
Used --trace, activated memory tracing, activated verbose mode.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12298

Differential Revision: https://secure.phabricator.com/D17389

Details

Auditors

CodeMouse92

Provenance

epriestley	Authored on Feb 20 2017, 8:04 PM
epriestley	Pushed on Feb 22 2017, 9:15 PM

Reviewer

chad

Differential Revision

D17389: Reorganize PhutilDaemon into Overseers, Pools and Daemons in libphutil

Parents

rPHUef580c9ccc21: In Phage, don't sit in a loop once we've read all messages from an agent

Branches

Unknown

Tags

Unknown

Tasks

T12298: Allow daemon pools to autoscale down to 0 processes

Build Status

Buildable 15726
Build 20780: Run Core Tests

Event Timeline

epriestley committed rPHUbe546154255c: Reorganize PhutilDaemon into Overseers, Pools and Daemons in libphutil (authored by epriestley).Feb 22 2017, 9:15 PM

epriestley added a task: T12298: Allow daemon pools to autoscale down to 0 processes.

Harbormaster completed building B15726: rPHUbe546154255c: Reorganize PhutilDaemon into Overseers, Pools and Daemons in libphutil.Feb 22 2017, 9:15 PM

Hey, the Chatbot is now refusing to start up since I pulled in the update with this commit. Here's the cursory stack trace:

[03-Mar-2017 16:36:06 America/Los_Angeles] [2017-03-03 16:36:06] EXCEPTION: (PhutilTypeMissingParametersException) Missing required parameters: label at [<phutil>/src/parser/PhutilTypeSpec.php:164]
[03-Mar-2017 16:36:06 America/Los_Angeles] arcanist(head=stable, ref.master=fe8ed2a6f8b0, ref.stable=822bc53ca306), phabricator(head=stable, ref.stable=216f6be11ece, custom=2), phutil(head=stable, ref.master=e509fc30ae78, ref.stable=76983f49b179)
[03-Mar-2017 16:36:06 America/Los_Angeles]   #0 PhutilTypeSpec::checkMap(array, array) called at [<phutil>/src/daemon/PhutilDaemonPool.php:31]
[03-Mar-2017 16:36:06 America/Los_Angeles]   #1 PhutilDaemonPool::newFromConfig(array) called at [<phutil>/src/daemon/PhutilDaemonOverseer.php:229]
[03-Mar-2017 16:36:06 America/Los_Angeles]   #2 PhutilDaemonOverseer::createDaemonPools() called at [<phutil>/src/daemon/PhutilDaemonOverseer.php:168]
[03-Mar-2017 16:36:06 America/Los_Angeles]   #3 PhutilDaemonOverseer::run() called at [<phabricator>/scripts/daemon/launch_daemon.php:24]

Not sure if I have enough info for a proper bug report. Your call?

This commit now has outstanding concerns.Mar 4 2017, 12:40 AM