Paths

Table of Contentst

Diffusion libphutil afc60bc131e1

Revert pht() of PhutilBootloader
Auditedafc60bc131e1
Actions

Tags

None

Referenced Files

None

Subscribers

Description

Revert pht() of PhutilBootloader

These errors can occur too early in the stack for pht() to work. See P1782 for an example.

Auditors: btrahan, joshuaspence

Details

Auditors

joshuaspence
btrahan

Group Auditors

Provenance

epriestley	Authored on
epriestley	Pushed on May 14 2015, 11:47 PM

Parents

rPHUdc4b8571f975: Make AphrontWriteGuard disposal more durable

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley committed rPHUafc60bc131e1: Revert pht() of PhutilBootloader (authored by epriestley).May 14 2015, 11:46 PM

epriestley added auditors: btrahan, joshuaspence.

Herald added auditors: Fakhra.Aftab, Cowboy Commits. · View Herald TranscriptMay 14 2015, 11:47 PM

joshuaspence accepted this commit.May 15 2015, 12:27 AM

joshuaspence added a subscriber: joshuaspence.

joshuaspence added inline comments.

/src/moduleutils/PhutilBootloader.php
3–7	Thanks for adding this... the same is probably true for `PhutilBootloaderException`.

Zolli mentioned this in D12736: Calendar event detail view should show "Unnamed Event" as title for events with no title.May 15 2015, 7:04 AM

chad accepted this commit.May 15 2015, 2:17 PM

btrahan accepted this commit.May 15 2015, 10:32 PM

• Karthik123 mentioned this in T8365: Initialization Error .May 30 2015, 11:42 AM

Changes (1)

Path

Size

src/

moduleutils/

PhutilBootloader.php

rPHUafc60bc131e1

src/moduleutils/PhutilBootloader.php

Loading...