HomePhabricator

Fix minor issues with PhrictionDocumentQuery

Description

Fix minor issues with PhrictionDocumentQuery

Summary:

  • Order checks used = but intended ==. We could probably write a lint rule for this.
  • Selecting * with a join could pick (for example) id columns from both the document and content tables and end up using the wrong one.
  • %Q expects a string and chokes on null.

Auditors: btrahan

Details

Auditors
btrahan
Group Auditors
Cowboy Commits
Provenance
epriestleyAuthored on
epriestleyPushed on Nov 12 2014, 2:49 AM
Parents
rP8e1a4eef0400: T4666, Support Herald in Phriction
Branches
Unknown
Tags
Unknown