Page MenuHomePhabricator

Provide a missing timeout on the non-cluster connection pathway
ClosedPublic

Authored by epriestley on Jun 29 2016, 6:18 PM.
Tags
None
Referenced Files
F13047952: D16194.diff
Thu, Apr 18, 3:20 PM
Unknown Object (File)
Sun, Apr 14, 12:34 PM
Unknown Object (File)
Thu, Apr 11, 8:44 AM
Unknown Object (File)
Tue, Apr 9, 6:18 AM
Unknown Object (File)
Mon, Apr 8, 8:00 PM
Unknown Object (File)
Mon, Apr 8, 1:36 PM
Unknown Object (File)
Mon, Apr 8, 10:37 AM
Unknown Object (File)
Mon, Apr 8, 7:59 AM
Subscribers
None

Details

Summary

Ref T11232. The cluster connection pathway specifies a timeout when connecting, but this connection pathway does not. (I'm not sure if we just never did or if it got lost at some point.)

Soon, T11044 will obsolete this and unify the database connection pathways, but that's a more complicated change.

I'm not sure if this will fix T11232, but it can't hurt.

Test Plan

Put a throw on timeout specifications. Before the change: did not hit it in non-cluster configurations. After the change: hit it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a missing timeout on the non-cluster connection pathway.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/infrastructure/storage/lisk/PhabricatorLiskDAO.php
102

\t

This revision is now accepted and ready to land.Jun 29 2016, 6:19 PM
This revision was automatically updated to reflect the committed changes.