HomePhabricator

Slightly simplify logic for determining if an inline comment has an effect

Description

Slightly simplify logic for determining if an inline comment has an effect

Summary: Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan: Made inlines, tried to submit empty comments. Behavior unchanged.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18468

Details

Provenance
epriestleyAuthored on Aug 24 2017, 10:15 PM
epriestleyPushed on Aug 24 2017, 10:26 PM
Reviewer
chad
Differential Revision
D18468: Slightly simplify logic for determining if an inline comment has an effect
Parents
rP6c9026c33a45: Allow ModularTransactions to opt in to providing data to Conduit
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18158
Build 24407: Run Core Tests