HomePhabricator

Fix start in fancy datepicker calendar

Description

Fix start in fancy datepicker calendar

Summary:
Fixes T9675.
Fixes the calculation for the difference between the first day of the month and the first day of the week. It was previously possible for this to be negative, which caused the subsequent loop to hang the browser.

Test Plan:

  • Set week to start on Sunday. Observed that the calendar still renders fine.
  • Set week to start on Monday. Observed that the browser no longer hangs on November 2015.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T9675

Differential Revision: https://secure.phabricator.com/D14409

Details

Provenance
0Authored on
epriestleyCommitted on Nov 5 2015, 3:07 PM
epriestleyPushed on Nov 5 2015, 3:07 PM
Reviewer
Blessed Reviewers
Differential Revision
D14409: Fix start in fancy datepicker calendar
Parents
rP6a035d977f22: Tweak grey tag color
Branches
Unknown
Tags
Unknown
Tasks
T9675: behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday
Build Status
Buildable 8628
Build 9984: Run Core Tests