Diffusion Phabricator 84353359de7c

(stable) Fix an intradiff error when the newer changeset does not exist
84353359de7c
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

(stable) Fix an intradiff error when the newer changeset does not exist

Summary: Ref T13523. If a file hasn't been touched in the newer changeset, we can currently hit an error in the interdiff.

Test Plan:

Touched "moo.txt" in Diff 1.
Reverted the changes to "moo.txt" in Diff 2.
Diffed 2 vs 1.
Before patch: fatal (call to getFilename() on null).
After patch: clean interdiff.

Maniphest Tasks: T13523

Differential Revision: https://secure.phabricator.com/D21220

Details

Provenance

epriestley	Authored on May 4 2020, 10:34 PM
epriestley	Pushed on May 4 2020, 10:42 PM

Differential Revision

D21220: Fix an intradiff error when the newer changeset does not exist

Parents

rPaa3b447bb0c8: (stable) Fix an issue where text intradiff bodies may not render

Branches

Unknown

Tags

Unknown

Tasks

T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes

Build Status

Buildable 24355
Build 33551: Run Core Tests

Event Timeline

epriestley committed rP84353359de7c: (stable) Fix an intradiff error when the newer changeset does not exist (authored by epriestley).May 4 2020, 10:42 PM

epriestley added a task: T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes.

epriestley added an edge: D21220: Fix an intradiff error when the newer changeset does not exist.

Harbormaster completed building B24355: rP84353359de7c: (stable) Fix an intradiff error when the newer changeset does not exist.May 4 2020, 10:44 PM

Changes (1)

Path

Size

src/

applications/

differential/

storage/

DifferentialChangeset.php

rP84353359de7c

src/applications/differential/storage/DifferentialChangeset.php

Loading...