Differential D21220

Fix an intradiff error when the newer changeset does not exist
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 10:38 PM.

Tags

None

Referenced Files

	F18101086: D21220.diff
	Sat, Aug 9, 12:19 PM

	F18090515: D21220.diff
	Wed, Aug 6, 4:07 PM

	F17947424: D21220.id.diff
	Thu, Jul 31, 4:31 PM

	F17928712: D21220.diff
	Wed, Jul 30, 4:20 PM

	F17916743: D21220.diff
	Tue, Jul 29, 10:35 PM

	Unknown Object (File)
	Jun 27 2025, 4:06 PM

	Unknown Object (File)
	May 28 2025, 4:05 PM

	Unknown Object (File)
	May 27 2025, 4:01 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes
Commits: rP84353359de7c: (stable) Fix an intradiff error when the newer changeset does not exist
rP6430d6d638eb: Fix an intradiff error when the newer changeset does not exist

Summary

Ref T13523. If a file hasn't been touched in the newer changeset, we can currently hit an error in the interdiff.

Test Plan

Touched "moo.txt" in Diff 1.
Reverted the changes to "moo.txt" in Diff 2.
Diffed 2 vs 1.
Before patch: fatal (call to getFilename() on null).
After patch: clean interdiff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 4 2020, 10:38 PM

Harbormaster completed remote builds in B24353: Diff 50536.May 4 2020, 10:40 PM

epriestley requested review of this revision.May 4 2020, 10:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:42 PM

Closed by commit rP6430d6d638eb: Fix an intradiff error when the newer changeset does not exist (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6430d6d638eb: Fix an intradiff error when the newer changeset does not exist.

epriestley added a commit: rP84353359de7c: (stable) Fix an intradiff error when the newer changeset does not exist.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialChangeset.php

6 lines

Diff 50538

src/applications/differential/storage/DifferentialChangeset.php

Loading...