Page MenuHomePhabricator

Fix an intradiff error when the newer changeset does not exist
ClosedPublic

Authored by epriestley on Mon, May 4, 10:38 PM.

Details

Summary

Ref T13523. If a file hasn't been touched in the newer changeset, we can currently hit an error in the interdiff.

Test Plan
  • Touched "moo.txt" in Diff 1.
  • Reverted the changes to "moo.txt" in Diff 2.
  • Diffed 2 vs 1.
  • Before patch: fatal (call to getFilename() on null).
  • After patch: clean interdiff.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 10:38 PM
epriestley requested review of this revision.Mon, May 4, 10:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 10:42 PM
This revision was automatically updated to reflect the committed changes.