HomePhabricator

Stop markup cache from hitting cache O(N^2) times

Description

Stop markup cache from hitting cache O(N^2) times

Summary:
The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan: "Query" tab of services is no longer quite so ridiculous in Differential.

Reviewers: btrahan, dctrwatson

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8352

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 26 2014, 9:17 PM
Reviewer
btrahan
Differential Revision
D8352: Stop markup cache from hitting cache O(N^2) times
Parents
rP7f5b15c6faaf: Made some classes final.
Branches
Unknown
Tags
Unknown

Event Timeline