Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
F15425919: D8352.diff
Sun, Mar 23, 6:38 AM
F15423647: D8352.id19851.diff
Sat, Mar 22, 4:29 PM
F15407236: D8352.diff
Tue, Mar 18, 4:28 PM
Unknown Object (File)
Feb 16 2025, 12:27 AM
Unknown Object (File)
Feb 15 2025, 9:34 AM
Unknown Object (File)
Feb 15 2025, 9:33 AM
Unknown Object (File)
Feb 15 2025, 9:33 AM
Unknown Object (File)
Feb 14 2025, 10:37 PM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped