Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2026, 10:42 AM
Unknown Object (File)
Jan 20 2026, 9:08 PM
Unknown Object (File)
Jan 9 2026, 4:51 PM
Unknown Object (File)
Dec 27 2025, 3:16 PM
Unknown Object (File)
Dec 24 2025, 5:24 AM
Unknown Object (File)
Nov 29 2025, 8:27 PM
Unknown Object (File)
Nov 29 2025, 7:04 PM
Unknown Object (File)
Nov 28 2025, 4:47 AM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped