Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
F14066514: D8352.diff
Tue, Nov 19, 10:11 AM
F14009382: D8352.diff
Wed, Oct 30, 3:44 PM
F14000057: D8352.id19860.diff
Thu, Oct 24, 7:08 PM
Unknown Object (File)
Oct 10 2024, 1:00 PM
Unknown Object (File)
Sep 21 2024, 6:43 AM
Unknown Object (File)
Sep 13 2024, 9:42 PM
Unknown Object (File)
Sep 13 2024, 9:41 PM
Unknown Object (File)
Sep 13 2024, 9:41 PM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped