Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
F13081904: D8352.diff
Wed, Apr 24, 9:54 PM
Unknown Object (File)
Sun, Apr 21, 4:14 PM
Unknown Object (File)
Wed, Apr 17, 3:19 PM
Unknown Object (File)
Thu, Apr 11, 7:32 AM
Unknown Object (File)
Sun, Apr 7, 1:08 PM
Unknown Object (File)
Mar 23 2024, 1:20 PM
Unknown Object (File)
Mar 21 2024, 10:26 AM
Unknown Object (File)
Feb 23 2024, 6:28 PM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped