Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 12:51 AM
Unknown Object (File)
Fri, Jan 17, 2:20 AM
Unknown Object (File)
Thu, Jan 16, 10:54 PM
Unknown Object (File)
Tue, Dec 24, 11:01 PM
Unknown Object (File)
Dec 20 2024, 6:31 AM
Unknown Object (File)
Dec 17 2024, 11:13 AM
Unknown Object (File)
Dec 13 2024, 7:20 AM
Unknown Object (File)
Dec 4 2024, 8:51 AM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped