Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
F19533906: D8352.diff
Tue, Jan 20, 9:08 PM
F19506723: D8352.id19860.diff
Fri, Jan 9, 4:51 PM
F19403949: D8352.diff
Dec 27 2025, 3:16 PM
F19303754: D8352.diff
Dec 24 2025, 5:24 AM
F19064273: D8352.id.diff
Nov 29 2025, 8:27 PM
F19063513: D8352.id19860.diff
Nov 29 2025, 7:04 PM
F19052364: D8352.diff
Nov 28 2025, 4:47 AM
F19048754: D8352.id.diff
Nov 27 2025, 3:26 PM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped