Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 5 2025, 6:07 AM
Unknown Object (File)
Apr 30 2025, 10:02 AM
Unknown Object (File)
Apr 28 2025, 1:47 AM
Unknown Object (File)
Apr 26 2025, 4:36 AM
Unknown Object (File)
Apr 26 2025, 2:06 AM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped