Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
F17701325: D8352.id19860.diff
Tue, Jul 15, 9:30 PM
F17700316: D8352.id.diff
Tue, Jul 15, 8:43 PM
F17695729: D8352.id19851.diff
Tue, Jul 15, 4:01 PM
F17686446: D8352.diff
Mon, Jul 14, 6:27 AM
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 6 2025, 9:11 AM
Unknown Object (File)
May 5 2025, 6:07 AM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped