HomePhabricator

Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey

Description

Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey

Summary: See PHI31. The "Accepted Older Revision" icon is (more reasonably) bluegrey, but that rule spilled over here where it doesn't make much sense. "Requested Changes to Prior Diff" remains in effect across updates, but the coloration implies otherwise.

Test Plan:
"Requested Changes to This Diff" (unchanged):

Screen Shot 2017-08-10 at 8.18.21 AM.png (198×422 px, 20 KB)

"Requested Changes to Prior Diff" (now red, previously bluegrey):

Screen Shot 2017-08-10 at 8.18.47 AM.png (242×457 px, 27 KB)

Note that the icons are different so this is technically colorblind-safe, and it's normally not important to distinguish between these two reds anyway.

Reviewers: chad, lvital

Reviewed By: lvital

Subscribers: lvital

Differential Revision: https://secure.phabricator.com/D18385

Details

Provenance
epriestleyAuthored on Aug 10 2017, 3:18 PM
epriestleyPushed on Aug 10 2017, 6:04 PM
Reviewer
lvital
Differential Revision
D18385: Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey
Parents
rP8443366f32d3: Remove `bin/files purge` workflow
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17986
Build 24153: Run Core Tests