Page MenuHomePhabricator

Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey
ClosedPublic

Authored by epriestley on Aug 10 2017, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 3, 11:37 PM
Unknown Object (File)
Mon, Aug 1, 12:10 AM
Unknown Object (File)
Wed, Jul 27, 6:46 AM
Unknown Object (File)
Sun, Jul 24, 3:17 AM
Unknown Object (File)
Sun, Jul 24, 3:16 AM
Unknown Object (File)
Wed, Jul 20, 9:03 AM
Unknown Object (File)
Tue, Jul 19, 10:23 PM
Unknown Object (File)
Tue, Jul 19, 10:23 PM
Subscribers

Details

Summary

See PHI31. The "Accepted Older Revision" icon is (more reasonably) bluegrey, but that rule spilled over here where it doesn't make much sense. "Requested Changes to Prior Diff" remains in effect across updates, but the coloration implies otherwise.

Test Plan

"Requested Changes to This Diff" (unchanged):

Screen Shot 2017-08-10 at 8.18.21 AM.png (198×422 px, 20 KB)

"Requested Changes to Prior Diff" (now red, previously bluegrey):

Screen Shot 2017-08-10 at 8.18.47 AM.png (242×457 px, 27 KB)

Note that the icons are different so this is technically colorblind-safe, and it's normally not important to distinguish between these two reds anyway.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable