HomePhabricator

Fix excessively harsh validation of certain complex configuration

Description

Fix excessively harsh validation of certain complex configuration

Summary:
See IRC. We're supposed to repair configuration, but if custom validators throw a generic Exception or use PhutilTypeSpec to do a check, we may explode way harder than we intend to.

Instead, soften these exceptions into validation exceptions so we repair configuration, raise a setup issue, and continue.

Test Plan:

Screen Shot 2016-01-11 at 2.16.15 PM.png (1×3 px, 385 KB)

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14998

Details

Provenance
epriestleyAuthored on Jan 11 2016, 10:15 PM
epriestleyPushed on Jan 11 2016, 10:20 PM
Reviewer
chad
Differential Revision
D14998: Fix excessively harsh validation of certain complex configuration
Parents
rP8e1b2f986151: Remove "username@phabricator.mycompany.com" creating a Conpherence
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10067
Build 12187: Run Core Tests