Page MenuHomePhabricator

Fix excessively harsh validation of certain complex configuration
ClosedPublic

Authored by epriestley on Jan 11 2016, 10:18 PM.
Tags
None
Referenced Files
F13283332: D14998.diff
Sun, Jun 2, 2:06 PM
F13269486: D14998.diff
Wed, May 29, 6:23 AM
F13258251: D14998.id36233.diff
Sun, May 26, 7:52 AM
F13254864: D14998.diff
Sat, May 25, 3:51 AM
F13250805: D14998.id.diff
Fri, May 24, 5:39 PM
F13236553: D14998.diff
Tue, May 21, 10:07 AM
F13234693: D14998.diff
Tue, May 21, 3:39 AM
F13217810: D14998.id36232.diff
Sat, May 18, 8:13 AM
Subscribers
None

Details

Summary

See IRC. We're supposed to repair configuration, but if custom validators throw a generic Exception or use PhutilTypeSpec to do a check, we may explode way harder than we intend to.

Instead, soften these exceptions into validation exceptions so we repair configuration, raise a setup issue, and continue.

Test Plan

Screen Shot 2016-01-11 at 2.16.15 PM.png (1×3 px, 385 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix excessively harsh validation of certain complex configuration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 10:19 PM
epriestley edited edge metadata.
  • "convert" instead of "conver"
This revision was automatically updated to reflect the committed changes.