HomePhabricator

Improve "thread" rendering of unusually-shaped graphs

Tags
None
Referenced Files
F1708161: Screen Shot 2016-07-01 at 9.52.10 AM.png
Jul 1 2016, 6:15 PM
F1708159: Screen Shot 2016-07-01 at 9.52.26 AM.png
Jul 1 2016, 6:15 PM
F1708160: Screen Shot 2016-07-01 at 9.55.31 AM.png
Jul 1 2016, 6:15 PM
F1708158: Screen Shot 2016-07-01 at 10.05.28 AM.png
Jul 1 2016, 6:15 PM
Subscribers
None

Description

Improve "thread" rendering of unusually-shaped graphs

Summary:
Ref T4788. This fixes all the bugs I was immediately able to catch:

  • "Directory-Like" graph shapes could draw too many vertical lines.
  • "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  • Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan:

  • Added failing tests and made them pass.

Screen Shot 2016-07-01 at 10.05.28 AM.png (368×481 px, 42 KB)

Screen Shot 2016-07-01 at 9.52.26 AM.png (328×418 px, 36 KB)

Screen Shot 2016-07-01 at 9.55.31 AM.png (370×380 px, 40 KB)

Screen Shot 2016-07-01 at 9.52.10 AM.png (330×360 px, 35 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788

Differential Revision: https://secure.phabricator.com/D16216