Page MenuHomePhabricator

Improve "thread" rendering of unusually-shaped graphs
ClosedPublic

Authored by epriestley on Jul 1 2016, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 8:13 PM
Unknown Object (File)
Feb 20 2024, 3:44 AM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 18 2024, 10:46 AM
Unknown Object (File)
Feb 12 2024, 12:03 AM
Unknown Object (File)
Feb 7 2024, 12:42 AM
Unknown Object (File)
Feb 3 2024, 11:12 AM
Subscribers
None

Details

Summary

Ref T4788. This fixes all the bugs I was immediately able to catch:

  • "Directory-Like" graph shapes could draw too many vertical lines.
  • "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  • Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan
  • Added failing tests and made them pass.

Screen Shot 2016-07-01 at 10.05.28 AM.png (368×481 px, 42 KB)

Screen Shot 2016-07-01 at 9.52.26 AM.png (328×418 px, 36 KB)

Screen Shot 2016-07-01 at 9.55.31 AM.png (370×380 px, 40 KB)

Screen Shot 2016-07-01 at 9.52.10 AM.png (330×360 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve "thread" rendering of unusually-shaped graphs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/infrastructure/diff/view/__tests__/PHUIDiffGraphViewTestCase.php
20–27

O.O

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 5:59 PM
This revision was automatically updated to reflect the committed changes.