HomePhabricator

Mostly move inline editing to DiffInline

Description

Mostly move inline editing to DiffInline

Summary:
Ref T12616. This doesn't pull over everything (some UI feedback didn't make it yet, and you can't cancel + undo cancelling edits yet) but editing comments technically works.

This is a little shaky, but feels less shaky than every other approach I've tried, so I think I'm finally on a reasonable track here.

Test Plan: Edited some inline comments.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616

Differential Revision: https://secure.phabricator.com/D17887

Details

Provenance
epriestleyAuthored on May 15 2017, 7:48 PM
epriestleyPushed on May 16 2017, 1:20 PM
Reviewer
chad
Differential Revision
D17887: Mostly move inline editing to DiffInline
Parents
rP4fd4ec3d275d: Hide inlines one-by-one, instead of in a big group
Branches
Unknown
Tags
Unknown
Tasks
T12616: Modernize display code for inline comments
Build Status
Buildable 16978
Build 22695: Run Core Tests