Page MenuHomePhabricator

Mostly move inline editing to DiffInline
ClosedPublic

Authored by epriestley on May 15 2017, 7:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:45 AM
Unknown Object (File)
Sun, Dec 8, 8:46 AM
Unknown Object (File)
Wed, Nov 27, 12:42 AM
Unknown Object (File)
Sat, Nov 23, 5:24 AM
Unknown Object (File)
Nov 21 2024, 5:46 AM
Unknown Object (File)
Nov 19 2024, 9:51 PM
Unknown Object (File)
Nov 19 2024, 9:49 PM
Unknown Object (File)
Nov 19 2024, 2:51 PM
Subscribers
None

Details

Summary

Ref T12616. This doesn't pull over everything (some UI feedback didn't make it yet, and you can't cancel + undo cancelling edits yet) but editing comments technically works.

This is a little shaky, but feels less shaky than every other approach I've tried, so I think I'm finally on a reasonable track here.

Test Plan

Edited some inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 15 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.