HomePhabricator

Migrate Project workboard to modular transactions

Description

Migrate Project workboard to modular transactions

Summary: This was interesting, because there were a mix of callsites using transactions and others that just set the property on the Project object. I made everything consistent in using transactions to change this property. I also found an implementation of getTitle() that I don't think is ever being invoked since shouldHide() is returning true, but I migrated it anyway.

Test Plan: Unit tests pass + enabling/disabling workboards (and importing).

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D18004

Details

Provenance
amckinleyAuthored on May 23 2017, 6:54 PM
amckinleyPushed on May 23 2017, 7:38 PM
Reviewer
Blessed Reviewers
Differential Revision
D18004: Migrate Project workboard to modular transactions
Parents
rP7e822fc94fa3: Update PhrictionContent for modular transactions
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17215
Build 23043: Run Core Tests