This was interesting, because there were a mix of callsites using transactions and others that just set the property on the Project object. I made everything consistent in using transactions to change this property. I also found an implementation of getTitle() that I don't think is ever being invoked since shouldHide() is returning true, but I migrated it anyway.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rP774fba3ce925: Migrate Project workboard to modular transactions
Unit tests pass + enabling/disabling workboards (and importing).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think these just didn't get converted when we swapped to transactions originally, your rewrites look correct to me.