Page MenuHomePhabricator

Migrate Project workboard to modular transactions
ClosedPublic

Authored by amckinley on May 23 2017, 7:07 PM.
Tags
None
Referenced Files
F18767507: D18004.diff
Tue, Oct 7, 10:54 PM
F18737867: D18004.id43301.diff
Wed, Oct 1, 1:04 PM
F18629412: D18004.diff
Sep 16 2025, 8:42 AM
F18566327: D18004.id.diff
Sep 9 2025, 2:29 PM
F18501130: D18004.diff
Sep 4 2025, 9:33 PM
F18064356: D18004.id43301.diff
Aug 4 2025, 1:28 PM
F17918842: D18004.id43301.diff
Jul 30 2025, 1:42 AM
F17908345: D18004.id.diff
Jul 29 2025, 1:41 PM
Subscribers

Details

Summary

This was interesting, because there were a mix of callsites using transactions and others that just set the property on the Project object. I made everything consistent in using transactions to change this property. I also found an implementation of getTitle() that I don't think is ever being invoked since shouldHide() is returning true, but I migrated it anyway.

Test Plan

Unit tests pass + enabling/disabling workboards (and importing).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think these just didn't get converted when we swapped to transactions originally, your rewrites look correct to me.

This revision is now accepted and ready to land.May 23 2017, 7:18 PM
This revision was automatically updated to reflect the committed changes.