Page MenuHomePhabricator

Migrate Project workboard to modular transactions
ClosedPublic

Authored by amckinley on May 23 2017, 7:07 PM.
Tags
None
Referenced Files
F15433998: D18004.diff
Tue, Mar 25, 1:29 AM
F15413244: D18004.diff
Wed, Mar 19, 5:37 PM
F15411297: D18004.diff
Wed, Mar 19, 8:59 AM
F15411242: D18004.diff
Wed, Mar 19, 8:56 AM
F15411176: D18004.diff
Wed, Mar 19, 8:53 AM
F15411040: D18004.diff
Wed, Mar 19, 8:48 AM
F15410974: D18004.diff
Wed, Mar 19, 8:45 AM
F15410148: D18004.diff
Wed, Mar 19, 6:50 AM
Subscribers

Details

Summary

This was interesting, because there were a mix of callsites using transactions and others that just set the property on the Project object. I made everything consistent in using transactions to change this property. I also found an implementation of getTitle() that I don't think is ever being invoked since shouldHide() is returning true, but I migrated it anyway.

Test Plan

Unit tests pass + enabling/disabling workboards (and importing).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think these just didn't get converted when we swapped to transactions originally, your rewrites look correct to me.

This revision is now accepted and ready to land.May 23 2017, 7:18 PM
This revision was automatically updated to reflect the committed changes.