HomePhabricator

Allow packages to be added as revision reviewers via the UI

Description

Allow packages to be added as revision reviewers via the UI

Summary:
Ref T10939. This lets you add packages as reviewers manually.

"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.

Test Plan:

  • Added a package as a reviewer manually.
  • Joined it, got authority over it.
  • Saw the review on my dashboard.
  • Accepted the revision, got authority extended to the package review.

Screen Shot 2016-05-13 at 10.50.44 AM.png (195×408 px, 21 KB)

Screen Shot 2016-05-13 at 10.51.09 AM.png (202×547 px, 24 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15914

Details

Provenance
epriestleyAuthored on May 13 2016, 5:51 PM
epriestleyPushed on May 14 2016, 12:20 AM
Reviewer
chad
Differential Revision
D15914: Allow packages to be added as revision reviewers via the UI
Parents
rP4ba4cb971178: Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon
Branches
Unknown
Tags
Unknown
Tasks
T10939: Support for OWNERS files
Build Status
Buildable 12204
Build 15409: Run Core Tests