Page MenuHomePhabricator

Allow packages to be added as revision reviewers via the UI
ClosedPublic

Authored by epriestley on May 13 2016, 5:54 PM.

Details

Summary

Ref T10939. This lets you add packages as reviewers manually.

"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.

Test Plan
  • Added a package as a reviewer manually.
  • Joined it, got authority over it.
  • Saw the review on my dashboard.
  • Accepted the revision, got authority extended to the package review.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38318.May 13 2016, 5:54 PM
epriestley retitled this revision from to Allow packages to be added as revision reviewers via the UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad added inline comments.May 13 2016, 7:35 PM
src/applications/differential/customfield/DifferentialProjectReviewersField.php
11

chad edited edge metadata.May 13 2016, 7:37 PM

Group seems slightly better. Or maybe team?

chad accepted this revision.May 13 2016, 7:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:37 PM
This revision was automatically updated to reflect the committed changes.

I did "Group Reviewers". ¯\_(ツ)_/¯