HomePhabricator

Fix a dashboard bucketing bug

Description

Fix a dashboard bucketing bug

Summary: Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's (string) !== (int). Just use != so this will still work if we turn it into a real string in the future.

Test Plan: Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15928

Details

Provenance
epriestleyAuthored on May 16 2016, 6:02 PM
epriestleyPushed on May 16 2016, 6:07 PM
Reviewer
chad
Differential Revision
D15928: Fix a dashboard bucketing bug
Parents
rP8a98868bfbc4: Remove "days fresh" / "days stale" indictator in Differential revision list
Branches
Unknown
Tags
Unknown
Tasks
T10939: Support for OWNERS files
Build Status
Buildable 12228
Build 15444: Run Core Tests