Page MenuHomePhabricator

Fix a dashboard bucketing bug
ClosedPublic

Authored by epriestley on May 16 2016, 6:04 PM.
Tags
None
Referenced Files
F18771107: D15928.id38354.diff
Wed, Oct 8, 5:35 PM
F18756356: D15928.id38353.diff
Sun, Oct 5, 11:04 AM
F18750903: D15928.id.diff
Sat, Oct 4, 9:14 AM
F18716769: D15928.id38353.diff
Sep 29 2025, 12:25 PM
F18507557: D15928.id.diff
Sep 5 2025, 2:16 AM
F18500125: D15928.diff
Sep 4 2025, 8:33 PM
F18459765: D15928.id.diff
Sep 1 2025, 5:54 PM
F18167013: D15928.id38353.diff
Aug 15 2025, 11:16 AM
Subscribers
None

Details

Summary

Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's (string) !== (int). Just use != so this will still work if we turn it into a real string in the future.

Test Plan

Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a dashboard bucketing bug.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 16 2016, 6:05 PM
This revision was automatically updated to reflect the committed changes.