HomePhabricator

Use %B when writing to Harbormaster build logs

Authored by hach-que.

Description

Use %B when writing to Harbormaster build logs

Summary: Fixes T7007. Using %B permits non-UTF8 data to be appended to Harbormaster build logs. Since we're not really in control of the processes Harbormaster is running remotely, and since they may output invalid UTF8 data, we should store the invalid data instead of failing the build (due to UTF8 exception).

Test Plan: @epriestley said this was the right fix, though I haven't tested it on our production system which actually exhibits the issue yet.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7007

Differential Revision: https://secure.phabricator.com/D11532

Details

Committed
hach-queJan 28 2015, 11:06 PM
Pushed
hach-queJan 28 2015, 11:06 PM
Reviewer
Blessed Reviewers
Differential Revision
D11532: Use %B when writing to Harbormaster build logs
Parents
rP8798083ad909: Proxy VCS SSH requests
Branches
Unknown
Tags
Unknown
Tasks
T7007: UTF8 exception occurring during Harbormaster build