Page MenuHomePhabricator

Use %B when writing to Harbormaster build logs
ClosedPublic

Authored by hach-que on Jan 28 2015, 1:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 11, 3:22 AM
Unknown Object (File)
Wed, Feb 7, 7:43 AM
Unknown Object (File)
Jan 28 2024, 2:47 AM
Unknown Object (File)
Jan 6 2024, 10:50 AM
Unknown Object (File)
Dec 15 2023, 4:00 PM
Unknown Object (File)
Dec 10 2023, 7:24 PM
Unknown Object (File)
Nov 30 2023, 3:02 AM
Unknown Object (File)
Nov 25 2023, 9:44 AM
Subscribers

Details

Summary

Fixes T7007. Using %B permits non-UTF8 data to be appended to Harbormaster build logs. Since we're not really in control of the processes Harbormaster is running remotely, and since they may output invalid UTF8 data, we should store the invalid data instead of failing the build (due to UTF8 exception).

Test Plan

@epriestley said this was the right fix, though I haven't tested it on our production system which actually exhibits the issue yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que retitled this revision from to Using %B when writing to Harbormaster build logs.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a subscriber: epriestley.
hach-que retitled this revision from Using %B when writing to Harbormaster build logs to Use %B when writing to Harbormaster build logs.Jan 28 2015, 1:18 AM
hach-que edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 7:11 PM
This revision was automatically updated to reflect the committed changes.