HomePhabricator

Don't create invalid build steps while adding them

Description

Don't create invalid build steps while adding them

Summary:
Ref T1049. Currently, the "add" dialog lets you select a build step type, but then immediately creates one. If you "cancel" from the edit screen, you end up with an empty (and almost certainly invalid) build step.

Instead, don't create the step until it's valid.

Test Plan: Add Step -> Pick Type -> Add Step -> Cancel no longer creates empty step.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D8605

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 25 2014, 11:12 PM
Reviewer
btrahan
Differential Revision
D8605: Don't create invalid build steps while adding them
Parents
rPd6b937ca2796: Allow external systems to send messages to build targets
Branches
Unknown
Tags
Unknown
Tasks
T1049: Implement Harbormaster

Event Timeline