Page MenuHomePhabricator

Don't create invalid build steps while adding them
ClosedPublic

Authored by epriestley on Mar 23 2014, 9:22 PM.
Tags
None
Referenced Files
F13051472: D8605.id20435.diff
Fri, Apr 19, 3:32 AM
F13051470: D8605.id20395.diff
Fri, Apr 19, 3:32 AM
F13051469: D8605.id.diff
Fri, Apr 19, 3:32 AM
Unknown Object (File)
Thu, Apr 11, 7:21 AM
Unknown Object (File)
Thu, Apr 11, 4:44 AM
Unknown Object (File)
Tue, Apr 9, 5:41 AM
Unknown Object (File)
Sat, Mar 30, 9:21 AM
Unknown Object (File)
Wed, Mar 27, 5:46 PM
Subscribers

Details

Summary

Ref T1049. Currently, the "add" dialog lets you select a build step type, but then immediately creates one. If you "cancel" from the edit screen, you end up with an empty (and almost certainly invalid) build step.

Instead, don't create the step until it's valid.

Test Plan

Add Step -> Pick Type -> Add Step -> Cancel no longer creates empty step.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't create invalid build steps while adding them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 8:52 PM
epriestley updated this revision to Diff 20435.

Closed by commit rP6e3c17e6f9fa (authored by @epriestley).