HomePhabricator

Improve error and large file handling in thumbnailing

Authored by epriestley.

Description

Improve error and large file handling in thumbnailing

Summary:
Ref T2479, T4406. We should do a better job of (a) handling image processing errors and (b) declining to process large image files.

This fixes the worst of it, which is that users can upload huge GIFs with a large number of frames and hang a convert process for a long time, eating a CPU and a pile of memory.

This code is still pretty iffy and needs some more work. A near-term product goal for it is supporting 100x100 profile images.

Test Plan: Uploaded large and small GIFs, after setting the definition of "enormous" to be pretty small. Saw the small GIFs thumbnail into animated GIFs, and the large ones thumbnail into static images.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2479, T4406

Differential Revision: https://secure.phabricator.com/D8536

Details

Committed
epriestleyMar 14 2014, 6:53 PM
Pushed
epriestleyMar 14 2014, 6:53 PM
Reviewer
btrahan
Differential Revision
D8536: Improve error and large file handling in thumbnailing
Parents
rP48910537b939: Fix rendering of comments deleted by editing
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task
T4406: Allow for 100x100 images in profile and projects

Event Timeline