HomePhabricator

Fix rendering of comments deleted by editing

Description

Fix rendering of comments deleted by editing

Summary:
Fixes T4609. Steps are:

  • Make a comment.
  • Edit it.
  • Delete all the text.

We expect to see "This comment has been deleted." -- instead, things currently render goofy.

Root cause is that hasComment() means both "comment object exists" and "comment object is nonempty".

Test Plan:

Screen_Shot_2014-03-14_at_8.07.39_AM.png (158×856 px, 22 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley

Maniphest Tasks: T4609

Differential Revision: https://secure.phabricator.com/D8533

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 14 2014, 6:53 PM
Reviewer
btrahan
Differential Revision
D8533: Fix rendering of comments deleted by editing
Parents
rP838f78128544: Add a robots.txt file to disallow /diffusion/
Branches
Unknown
Tags
Unknown
Tasks
T4609: If you edit a comment to delete it, it displays wrong

Event Timeline