Prepare DestructionEngine to be modularized


Prepare DestructionEngine to be modularized

Ref T9979. The general shape of "engine" code feels pretty good, and I plan to move indexing to be more in line with other modern engines, with the ultimate goal of supporting subprojects (T10010) and several intermediate goals.

Before moving indexing, clean up Destruction, since some of the new indexes will need destruction hooks and destruction currently has a lot of instanceof stuff that should be easy to fix by applying more modern approaches.

Test Plan:

  • Used bin/remove destroy to destory an Almanac device.
  • Verified that properties for the device were destroyed.
  • Viewed module panel in UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9979

Differential Revision: https://secure.phabricator.com/D14831