Page MenuHomePhabricator

Prepare DestructionEngine to be modularized

Authored by epriestley on Dec 20 2015, 3:54 PM.
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:57 PM
Unknown Object (File)
Thu, Apr 18, 4:19 PM
Unknown Object (File)
Wed, Apr 17, 2:47 PM
Unknown Object (File)
Thu, Apr 11, 5:05 AM
Unknown Object (File)
Mon, Apr 1, 12:26 AM
Unknown Object (File)
Thu, Mar 28, 10:57 PM
Unknown Object (File)
Tue, Mar 26, 3:07 AM
Unknown Object (File)
Mar 5 2024, 3:41 PM



Ref T9979. The general shape of "engine" code feels pretty good, and I plan to move indexing to be more in line with other modern engines, with the ultimate goal of supporting subprojects (T10010) and several intermediate goals.

Before moving indexing, clean up Destruction, since some of the new indexes will need destruction hooks and destruction currently has a lot of instanceof stuff that should be easy to fix by applying more modern approaches.

Test Plan
  • Used bin/remove destroy to destory an Almanac device.
  • Verified that properties for the device were destroyed.
  • Viewed module panel in UI.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare DestructionEngine to be modularized.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2015, 4:05 PM
This revision was automatically updated to reflect the committed changes.