Page MenuHomePhabricator

Prepare DestructionEngine to be modularized
ClosedPublic

Authored by epriestley on Dec 20 2015, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 8:18 PM
Unknown Object (File)
Tue, Nov 29, 8:17 PM
Unknown Object (File)
Tue, Nov 29, 8:17 PM
Unknown Object (File)
Thu, Nov 17, 5:34 AM
Unknown Object (File)
Wed, Nov 16, 7:00 AM
Unknown Object (File)
Sat, Nov 12, 4:25 PM
Unknown Object (File)
Fri, Nov 11, 10:12 PM
Unknown Object (File)
Thu, Nov 10, 2:40 AM
Subscribers
None

Details

Summary

Ref T9979. The general shape of "engine" code feels pretty good, and I plan to move indexing to be more in line with other modern engines, with the ultimate goal of supporting subprojects (T10010) and several intermediate goals.

Before moving indexing, clean up Destruction, since some of the new indexes will need destruction hooks and destruction currently has a lot of instanceof stuff that should be easy to fix by applying more modern approaches.

Test Plan
  • Used bin/remove destroy to destory an Almanac device.
  • Verified that properties for the device were destroyed.
  • Viewed module panel in UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare DestructionEngine to be modularized.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2015, 4:05 PM
This revision was automatically updated to reflect the committed changes.