HomePhabricator

Remove Controller->getHandle() and Controller->loadHandles()

Description

Remove Controller->getHandle() and Controller->loadHandles()

Summary: Ref T7689. Modernize all callsites of these methods.

Test Plan:

  • Poked at dashboards.
    • Pretty sure this code is technically unreachable right now.
  • Viewed commit; viewed "Audit Status".
  • Viewed a fund; viewed "Payable to"; viewed "Owner".
  • Viewed herald rules; viewed "Author"; viewed "Applies To".
  • Viewed a Legalpad document; viewed "Contributors".
  • Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
  • Viewed a macro; viewed "Audio".
  • Viewed a Phriction page; viewed "Last Author".
  • Viewed a Ponder question; viewed "Author".
  • Viewed a Ponder answer; viewed header.
    • Behavior changed very slightly here; whatevs.
  • Viewed a Countdown; viewed "Author".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7689

Differential Revision: https://secure.phabricator.com/D12210

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 31 2015, 12:48 PM
Reviewer
btrahan
Differential Revision
D12210: Remove Controller->getHandle() and Controller->loadHandles()
Parents
rP0f52fc771dc0: Remove implode_selected_handle_links()
Branches
Unknown
Tags
Unknown
Tasks
T7689: Load handles just-in-time