HomePhabricator

Remove "Show All Context" button from Diffusion

Description

Remove "Show All Context" button from Diffusion

Summary:
Ref T12616. Diffusion, only, has a "Show All Context" button which expands the full context on all changes.

I don't remember the exact history on this, but it hasn't existed in Differential for some time and no one has complained. I suspect that the "View Options > Show All Context" on each file may replace it. I can't really come up with good reasons to use it, offhand. If we want to restore it, I think global options after T1591 is promising.

Screen Shot 2017-05-08 at 9.58.04 AM.png (309×425 px, 33 KB)

Test Plan:

  • Loaded a commit in Diffusion, no longer saw a button.
  • Grepped for relevant sigils.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616

Differential Revision: https://secure.phabricator.com/D17843

Details

Provenance
epriestleyAuthored on May 8 2017, 5:00 PM
epriestleyPushed on May 16 2017, 1:17 PM
Reviewer
chad
Differential Revision
D17843: Remove "Show All Context" button from Diffusion
Parents
rP2bd25d7399c5: Rename "DifferentialChangesetViewManager" to "DiffChangeset"
Branches
Unknown
Tags
Unknown
Tasks
T12616: Modernize display code for inline comments
Build Status
Buildable 16974
Build 22691: Run Core Tests